[PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n

Michael Ellerman mpe at ellerman.id.au
Fri Jan 23 15:13:05 AEDT 2015


On Thu, 2015-01-22 at 23:03 -0500, Pranith Kumar wrote:
> On Thu, Jan 22, 2015 at 5:35 PM, Stewart Smith
> <stewart at linux.vnet.ibm.com> wrote:
> > Pranith Kumar <bobby.prani at gmail.com> writes:
> >> On Thu, Jan 22, 2015 at 12:19 AM, Michael Ellerman <mpe at ellerman.id.au> wrote:
> >>> On Wed, 2015-01-21 at 21:26 -0500, Pranith Kumar wrote:
> >>>> When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get()
> >>>> return 0. Check for these return values and skip registering the dump buffer.
> >>>>
> >>>> Signed-off-by: Pranith Kumar <bobby.prani at gmail.com>
> >>>> CC: Michael Ellerman <mpe at ellerman.id.au>
> >>>> ---
> >>>>  arch/powerpc/platforms/powernv/opal.c | 6 ++++++
> >>>>  1 file changed, 6 insertions(+)
> >>>
> >>> What changed since v1? I don't see anything?
> >>
> >> Nothing in this patch but there is a v2 of the first patch in this
> >> series, so had to resend this patch with a v2.

OK. You didn't send patch 1 to the this list though, so I only saw it on lkml.
Please don't do that in future.

> > You also missed my Reviewed-by :)
> 
> Sincere apologies for the oversight. Maintainers, could you please add
> this Reviewed-by tag when picking this up?
> 
> Reviewed-by: Stewart Smith <stewart at linux.vnet.ibm.com>

For future reference patchwork will catch these tags automatically. So if you
have forgotten to add them you can always reply to your own patch like you have
here and patchwork will detect them.

eg:

http://patchwork.ozlabs.org/patch/431648/mbox/

cheers




More information about the Linuxppc-dev mailing list