[PATCH 1/3] CXL: Add image control to sysfs

Ian Munsie imunsie at au1.ibm.com
Fri Jan 16 15:15:30 AEDT 2015


Hi Ryan,

Excerpts from Ryan Grimm's message of 2015-01-16 09:27:15 +1100:
> reset_image_select identifies whether a PERST will cause the image to be

s/reset_image_select/load_image_on_perst/

> +What:           /sys/class/cxl/<card>/load_image_on_perst
> +Date:           December 2014
> +Contact:        linuxppc-dev at lists.ozlabs.org
> +Description:    read/write
> +                Value of "none" means PERST will not cause image to be loaded
> +                to the card.  A power cycle is required to load the image.  

git am spotted some whitespace at the end of this line.


> +int cxl_update_image_control(struct cxl *adapter)

Would you be able to pull this function out into a separate patch (can
be first in the series so everything still compiles after each patch)
along with the change to the image_state defaults from patch 3? It's a
fix that I think would be good to be backported to stable, which will be
simpler if it's in a separate patch.



Otherwise, looks good :)

Acked-by: Ian Munsie <imunsie at au1.ibm.com>



More information about the Linuxppc-dev mailing list