[Xen-devel] [PATCH 3/8] x86/xen/p2m: Replace ACCESS_ONCE with READ_ONCE
Christian Borntraeger
borntraeger at de.ibm.com
Thu Jan 15 22:07:11 AEDT 2015
Am 15.01.2015 um 11:43 schrieb David Vrabel:
> On 15/01/15 08:58, Christian Borntraeger wrote:
>> ACCESS_ONCE does not work reliably on non-scalar types. For
>> example gcc 4.6 and 4.7 might remove the volatile tag for such
>> accesses during the SRA (scalar replacement of aggregates) step
>> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145)
>>
>> Change the p2m code to replace ACCESS_ONCE with READ_ONCE.
>
> Acked-by: David Vrabel <david.vrabel at citrix.com>
Thanks
> Let me know if you want me to merge this via the Xen tree.
With your Acked-by, I can easily carry this in my tree. We can
then ensure that this patch is merged before the ACCESS_ONCE is
made stricter - making bisecting easier.
Christian
More information about the Linuxppc-dev
mailing list