[PATCH v3 1/3] Revert "clk: ppc-corenet: Fix Section mismatch warning"
Yuantian Tang
Yuantian.Tang at freescale.com
Thu Jan 15 13:50:33 AEDT 2015
PING!
Thanks,
Yuantian
> -----Original Message-----
> From: Kevin Hao [mailto:haokexin at gmail.com]
> Sent: Wednesday, December 03, 2014 4:54 PM
> To: linuxppc-dev at lists.ozlabs.org
> Cc: Benjamin Herrenschmidt; Wood Scott-B07421; Mike Turquette; Lu
> Jingchang-B35083; Gerhard Sittig; Tang Yuantian-B29983
> Subject: [PATCH v3 1/3] Revert "clk: ppc-corenet: Fix Section mismatch warning"
>
> This reverts commit da788acb28386aa896224e784954bb73c99ff26c.
>
> That commit tried to fix the section mismatch warning by moving the
> ppc_corenet_clk_driver struct to init section. This is definitely wrong because the
> kernel would free the memories occupied by this struct after boot while this
> driver is still registered in the driver core.
> The kernel would panic when accessing this driver struct.
>
> Cc: stable at vger.kernel.org # 3.17
> Signed-off-by: Kevin Hao <haokexin at gmail.com>
> Acked-by: Scott Wood <scottwood at freescale.com>
> Acked-by: Michael Turquette <mturquette at linaro.org>
> ---
> v3: Cc stable and add ack.
>
> v2: A new patch in v2.
>
> drivers/clk/clk-ppc-corenet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-ppc-corenet.c index
> b6e6c85507a5..0a47d6f49cd6 100644
> --- a/drivers/clk/clk-ppc-corenet.c
> +++ b/drivers/clk/clk-ppc-corenet.c
> @@ -291,7 +291,7 @@ static const struct of_device_id ppc_clk_ids[] __initconst
> = {
> {}
> };
>
> -static struct platform_driver ppc_corenet_clk_driver __initdata = {
> +static struct platform_driver ppc_corenet_clk_driver = {
> .driver = {
> .name = "ppc_corenet_clock",
> .of_match_table = ppc_clk_ids,
> --
> 1.9.3
More information about the Linuxppc-dev
mailing list