[PATCH] powerpc/powernv: check OPAL_REGISTER_DUMP_REGION calls exist

Stewart Smith stewart at linux.vnet.ibm.com
Thu Feb 26 08:53:52 AEDT 2015


Cedric Le Goater <clg at fr.ibm.com> writes:
> On 02/25/2015 10:16 PM, Stewart Smith wrote:
>> Cédric Le Goater <clg at fr.ibm.com> writes:
>>> On Open Power systems, such call fails in OPAL : 
>>>
>>>    OPAL: Called with bad token 101 !
>>>
>>> The check on the OPAL_UNREGISTER_DUMP_REGION call is added for 
>>> symmetry. I did not see any errors for it.
>> 
>> I've already put in a patch to squash this:
>> Message-Id:
>> <1423718729-17992-2-git-send-email-stewart at linux.vnet.ibm.com>
>> 
>> Just waiting on mpe to merge :)
>
> ok fine, I missed it :) 
>
> I am also tempted to fix OPAL_READ_TPO but the proper way to do this 
> would be to move the lowlevel OPAL code from drivers/rtc/rtc-opal.c to 
> a new file under arch/powerpc/platforms/powernv/. How does that sound ? 

shouldn't we be detecting things from DT and acting on it? From a quick
glance perhaps we're not quite doing the checks in all the right places?



More information about the Linuxppc-dev mailing list