[PATCH 4/4] powerpc/mpic: remove unused functions

Arseny Solokha asolokha at kb.kras.ru
Fri Feb 20 15:40:33 AEDT 2015


> If I just get a patch saying "removed unused foo()", I have to go and dig and
> find out:
>   - was it recently added and will be used soon?
>   - is it ancient and never used, if so can we work out why, ie. feature X
>     never landed so this code is no longer needed.
>   - is it old code that *was* used but isn't now because commit ... removed the
>     last user.
>   - is it code that *should* be used, but isn't for some odd reason?
>
>
> So if you can provide that sort of detail for me, that really adds value to the
> patch. Otherwise the patch is basically just a TODO for me, to go and work out
> why the code is unused.

Got it. Will resend the whole series one of these days.

Arsény


> cheers


More information about the Linuxppc-dev mailing list