[PATCH v2 0/4] VPHN parsing fixes

Michael Ellerman mpe at ellerman.id.au
Wed Feb 4 11:42:37 AEDT 2015


On Tue, 2015-02-03 at 08:46 +0100, Greg Kurz wrote:
> On Tue, 03 Feb 2015 13:47:35 +1100
> Michael Ellerman <mpe at ellerman.id.au> wrote:
> 
> > On Thu, 2015-01-29 at 19:03 +0100, Greg Kurz wrote:
> > > On Wed, 17 Dec 2014 10:40:46 +0100
> > > Greg Kurz <gkurz at linux.vnet.ibm.com> wrote:
> > > > Hi,
> > > > 
> > > > This series addresses remarks from Ben and Michael (see individual patches).
> > > > The most notable changes are:
> > > > - the parsing code being pull out into a separate file in patch 3/4. This
> > > >   allows to write userland tests like the one below.
> > > > - a full rewrite of the parsing logic in patch 4/4
> > > > 
> > > 
> > > Ping ?
> > 
> > Sorry, lots of patches needing review.
> 
> Heh, no problem. :) Since this isn't bugfix, I can even repost later, when
> the review pressure is lower.

Yeah if you can repost in ~2 weeks that would be perfect.
 
> > This looks pretty good at a glance, but did you actually write a userspace test
> > for it? If so please send it. I'm happy to rework it into something that can go
> > in selftests.
> > 
> 
> Yes, I wrote the premise of a test program. You can find it in the cover mail of
> this series:
> 
> https://lists.ozlabs.org/pipermail/linuxppc-dev/2014-December/123601.html
> 
> I'll have a look at selftests.

Thanks. That test looks like a good start, there might be some more cases to
test though?

If you just copy the tools/testing/selftests/powerpc/tm directory and rename to
vhpn, you can probably work out the rest.

cheers




More information about the Linuxppc-dev mailing list