[1/2] mpc85xx/lbc: modify suspend/resume entry sequence

[Kushwaha Prabhakar]

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Thursday, December 24, 2015 10:19 AM
> To: Kushwaha Prabhakar-B32579 <prabhakar at freescale.com>; Dogra
> Raghav-B46184 <raghav at freescale.com>
> Cc: linuxppc-dev at lists.ozlabs.org
> Subject: Re: [1/2] mpc85xx/lbc: modify suspend/resume entry sequence
> 
> On Wed, 2015-12-23 at 22:38 -0600, Kushwaha Prabhakar-B32579 wrote:
> > > -----Original Message-----
> > > From: Wood Scott-B07421
> > > Sent: Thursday, December 24, 2015 9:49 AM
> > > To: Dogra Raghav-B46184 <raghav at freescale.com>
> > > Cc: linuxppc-dev at lists.ozlabs.org; Kushwaha Prabhakar-B32579
> > > <prabhakar at freescale.com>
> > > Subject: Re: [1/2] mpc85xx/lbc: modify suspend/resume entry sequence
> > >
> > > On Fri, Oct 30, 2015 at 11:54:59AM +0530, Raghav Dogra wrote:
> > > >  /* restore lbc registers */
> > > > -static int fsl_lbc_resume(struct platform_device *pdev)
> > > > +static int fsl_lbc_syscore_resume(void)
> > > >  {
> > > > -	struct fsl_lbc_ctrl *ctrl = dev_get_drvdata(&pdev->dev);
> > > > -	struct fsl_lbc_regs __iomem *lbc = ctrl->regs;
> > > > +	struct fsl_lbc_ctrl *ctrl;
> > > > +	struct fsl_lbc_regs __iomem *lbc;
> > > > +
> > > > +	ctrl = fsl_lbc_ctrl_dev;
> > > > +	if (!ctrl)
> > > > +		goto out;
> > > > +
> > > > +	lbc = ctrl->regs;
> > > > +	if (!lbc)
> > > > +		goto out;
> > > >
> > > >  	if (ctrl->saved_regs) {
> > > >  		_memcpy_toio(lbc, ctrl->saved_regs, @@ -379,7 +398,9 @@
> > > static int
> > > > fsl_lbc_resume(struct platform_device *pdev)
> > > >  		kfree(ctrl->saved_regs);
> > > >  		ctrl->saved_regs = NULL;
> > > >  	}
> > > > -	return 0;
> > > > +
> > > > +out:
> > > > +	return;
> > > >  }
> > >
> > > arch/powerpc/sysdev/fsl_lbc.c:401:2: error:
> > > 'return' with no value, in function returning non-void
> > > [-Werror=return -type]
> > >
> > >
> > > >  #endif /* CONFIG_SUSPEND */
> > > >
> > > > @@ -391,20 +412,26 @@ static const struct of_device_id
> > > > fsl_lbc_match[] =
> > > {
> > > >  	{},
> > > >  };
> > > >
> > > > +#ifdef CONFIG_SUSPEND
> > > > +static struct syscore_ops lbc_syscore_pm_ops = {
> > > > +	.suspend = fsl_lbc_syscore_suspend,
> > > > +	.resume = fsl_lbc_syscore_resume, }; #endif
> > >
> > > arch/powerpc/sysdev/fsl_lbc.c:416:2: error:
> > > initialization from incompatible pointer type [-Werror]
> > > arch/powerpc/sysdev/fsl_lbc.c:416:2: error:
> > > (near initialization for 'lbc_syscore_pm_ops.resume') [-Werror]
> > >
> >
> > Can you please help us with the tool-chain used for compiling.
> 
> It doesn't matter.  The patch is clearly wrong based on inspection.
> 

Can you please help me with the things which needs to be updated
Or 
Complete patch is wrong.

--prabhakar