[v8, 2/6] fsl/fman: Add FMan support

[Liberman Igal]

Hi David,
Thank you for your feedback, I'll address it and re-submit.

Regards,
Igal Liberman

> -----Original Message-----
> From: David Miller [mailto:davem at davemloft.net]
> Sent: Tuesday, December 01, 2015 11:28 PM
> To: Liberman Igal-B31950 <Igal.Liberman at freescale.com>
> Cc: netdev at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; linux-
> kernel at vger.kernel.org; Wood Scott-B07421 <scottwood at freescale.com>;
> Bucur Madalin-Cristian-B32716 <madalin.bucur at freescale.com>;
> pebolle at tiscali.nl; joakim.tjernlund at transmode.se; ppc at mindchasers.com;
> stephen at networkplumber.org
> Subject: Re: [v8, 2/6] fsl/fman: Add FMan support
> 
> From: <igal.liberman at freescale.com>
> Date: Mon, 30 Nov 2015 14:20:58 +0200
> 
> > +typedef irqreturn_t (fman_exceptions_cb)(struct fman *fman,
> > +					 enum fman_exceptions exception);
> 
> Function and function pointer declarations and definitions should be
> indented such that the second and subsequent lines begin precisely at the
> first column after the openning parenthesis of the first line.
> 
> Please audit this and fix it in your entire submission, almost ever new such
> case is done incorrectly.
> 
> > +	fman->state->exceptions = (EX_DMA_BUS_ERROR                 |
> > +					EX_DMA_READ_ECC              |
> > +					EX_DMA_SYSTEM_WRITE_ECC      |
> > +					EX_DMA_FM_WRITE_ECC          |
> > +					EX_FPM_STALL_ON_TASKS        |
> > +					EX_FPM_SINGLE_ECC            |
> > +					EX_FPM_DOUBLE_ECC            |
> > +
> 	EX_QMI_DEQ_FROM_UNKNOWN_PORTID |
> > +					EX_BMI_LIST_RAM_ECC          |
> > +					EX_BMI_STORAGE_PROFILE_ECC   |
> > +					EX_BMI_STATISTICS_RAM_ECC    |
> > +					EX_MURAM_ECC                 |
> > +					EX_BMI_DISPATCH_RAM_ECC      |
> > +					EX_QMI_DOUBLE_ECC            |
> > +					EX_QMI_SINGLE_ECC);
> 
> The same applies to multi-line parenthesized expressions like this one.
> Again, please audit and fix this in your entire submission.
> 
> Thanks.