[PATCH 3/3] mm: use numa_mem_id() in alloc_pages_node()

Vlastimil Babka vbabka at suse.cz
Thu Aug 20 21:43:22 AEST 2015

alloc_pages_node() might fail when called with NUMA_NO_NODE and
__GFP_THISNODE on a CPU belonging to a memoryless node. To make the
local-node fallback more robust and prevent such situations, use
numa_mem_id(), which was introduced for similar scenarios in the slab

Suggested-by: Christoph Lameter <cl at linux.com>
Signed-off-by: Vlastimil Babka <vbabka at suse.cz>
Acked-by: David Rientjes <rientjes at google.com>
Acked-by: Mel Gorman <mgorman at techsingularity.net>
Acked-by: Christoph Lameter <cl at linux.com>
 v3: better commit message

 include/linux/gfp.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/linux/gfp.h b/include/linux/gfp.h
index 4a12cae2..f92cbd2 100644
--- a/include/linux/gfp.h
+++ b/include/linux/gfp.h
@@ -318,13 +318,14 @@ __alloc_pages_node(int nid, gfp_t gfp_mask, unsigned int order)
  * Allocate pages, preferring the node given as nid. When nid == NUMA_NO_NODE,
- * prefer the current CPU's node. Otherwise node must be valid and online.
+ * prefer the current CPU's closest node. Otherwise node must be valid and
+ * online.
 static inline struct page *alloc_pages_node(int nid, gfp_t gfp_mask,
 						unsigned int order)
 	if (nid == NUMA_NO_NODE)
-		nid = numa_node_id();
+		nid = numa_mem_id();
 	return __alloc_pages_node(nid, gfp_mask, order);

More information about the Linuxppc-dev mailing list