[PATCH 0/3] PCI: arm64/powerpc: Fix parsing of linux,pci-probe-only
Marc Zyngier
marc.zyngier at arm.com
Sat Aug 15 00:41:05 AEST 2015
The pci-host-generic driver parses the linux,pci-probe-only property,
and assumes that it will have a boolean parameter.
Turns out that the Seattle DTS file has a naked "linux,pci-probe-only"
property, which leads to the driver dereferencing some unsuspecting
memory location. Nothing really bad happens (we end up reading some
other bit of DT, fortunately), but that not a reason to keep it this
way.
The first patch fixes the driver not to do silly things, and simply
give a warning when this happens. The powerpc code from where this
code was lifted is also fixed in a second patch.
Finally, the bad property is removed from the Seatle DTS, because it
is simply not necessary (it actually prevents me from using SR-IOV,
which otherwise runs fine without the probe-only thing).
Marc Zyngier (3):
PCI: pci-host-generic: Fix lookup of linux,pci-probe-only property
powerpc: PCI: Fix lookup of linux,pci-probe-only property
arm64: dts: Drop linux,pci-probe-only from the Seattle DTS
arch/arm64/boot/dts/amd/amd-overdrive.dts | 1 -
arch/powerpc/platforms/pseries/setup.c | 15 ++++++++++-----
drivers/pci/host/pci-host-generic.c | 15 ++++++++++-----
3 files changed, 20 insertions(+), 11 deletions(-)
--
2.1.4
More information about the Linuxppc-dev
mailing list