[v2 8/9] dpaa_eth: add debugfs entries

Madalin-Cristian Bucur madalin.bucur at freescale.com
Tue Aug 11 21:00:39 AEST 2015


> -----Original Message-----
> From: David Miller [mailto:davem at davemloft.net]
> 
> From: Madalin Bucur <madalin.bucur at freescale.com>
> Date: Wed, 5 Aug 2015 18:41:28 +0300
> 
> > Export per CPU counters through debugfs.
> >
> > Signed-off-by: Madalin Bucur <madalin.bucur at freescale.com>
> 
> This is absolutely inappropriate.
> 
> You can export these just fine via ethtool statistics.  There is zero reason
> to add ugly debugfs crap for something like this.

If you have such a strong adversity about the debugfs, then I'll export these
debug counters through ethtool statistics in the next version.

Madalin


More information about the Linuxppc-dev mailing list