[PATCH v2 04/10] cxl: Clean up adapter MMIO unmap path.

Daniel Axtens dja at axtens.net
Tue Aug 11 16:38:04 AEST 2015


Hi Cyril,
> >  - PCI regions are allocated in cxl_map_adapter_regs.
> >    Therefore they should be released in unmap, not elsewhere.
> > 
> 
> You've changed the order in which cxl_remove_adapter() does its work, which,
> I'm sure you've considered and it's fine, best to check.

Yeah, I have considered this. I've also tested it a lot.

Thanks for the review.

> Acked-by: Cyril Bur <cyrilbur at gmail.com>


-- 
Regards,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 860 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20150811/b4eea926/attachment.sig>


More information about the Linuxppc-dev mailing list