[PATCH 1/8] misc: cxl: clean up afu_read_config()
Michael Neuling
mikey at neuling.org
Wed Aug 5 17:48:00 AEST 2015
On Mon, 2015-07-27 at 00:18 +0300, Vladimir Zapolskiy wrote:
> The sanity checks for overflow are not needed, because this is done on
> caller side in fs/sysfs/file.c
>
> Signed-off-by: Vladimir Zapolskiy <vz at mleia.com>
> Cc: linuxppc-dev at lists.ozlabs.org
> Cc: Ian Munsie <imunsie at au1.ibm.com>
> Cc: Michael Neuling <mikey at neuling.org>
Acked-by: Michael Neuling <mikey at neuling.org>
> ---
> drivers/misc/cxl/sysfs.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/misc/cxl/sysfs.c b/drivers/misc/cxl/sysfs.c
> index 31f38bc..87cd747 100644
> --- a/drivers/misc/cxl/sysfs.c
> +++ b/drivers/misc/cxl/sysfs.c
> @@ -443,12 +443,7 @@ static ssize_t afu_read_config(struct file *filp, struct kobject *kobj,
> struct afu_config_record *cr = to_cr(kobj);
> struct cxl_afu *afu = to_cxl_afu(container_of(kobj->parent, struct device, kobj));
>
> - u64 i, j, val, size = afu->crs_len;
> -
> - if (off > size)
> - return 0;
> - if (off + count > size)
> - count = size - off;
> + u64 i, j, val;
>
> for (i = 0; i < count;) {
> val = cxl_afu_cr_read64(afu, cr->cr, off & ~0x7);
More information about the Linuxppc-dev
mailing list