[PATCH V2] clockevents: Fix cpu down race for hrtimer based broadcasting
Peter Zijlstra
peterz at infradead.org
Thu Apr 2 23:02:56 AEDT 2015
On Thu, Apr 02, 2015 at 12:42:27PM +0200, Ingo Molnar wrote:
> So why not use a suitable CPU_DOWN* notifier for this, instead of open
> coding it all into a random place in the hotplug machinery?
Because notifiers are crap? ;-) Its entirely impossible to figure out
what's happening to core code in hotplug. You need to go chase down and
random order notifier things.
I'm planning on taking out many of the core hotplug notifiers and hard
coding their callbacks into the hotplug code.
That way at least its clear wtf happens when.
> Also, I improved the changelog (attached below), but decided against
> applying it until these questions are cleared - please use that for
> future versions of this patch.
> Fixes: http://linuxppc.10917.n7.nabble.com/offlining-cpus-breakage-td88619.html
You forgot to fix the Fixes line ;-)
My copy has:
Fixes: 5d1638acb9f6 ("tick: Introduce hrtimer based broadcast")
More information about the Linuxppc-dev
mailing list