[PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

Timur Tabi timur at tabi.org
Wed Sep 10 05:37:42 EST 2014


On 09/09/2014 01:38 PM, Nicolin Chen wrote:
> make sure to have the call for imx only because it seems that
> the other platforms do not depend on the clock.

Although I doubt anyone will every add support for clocks to PowerPC 
"side" of this driver, I would prefer to avoid IMX-specific changes. 
Instead, the code should check if a clock is available.  That's why I 
suggested this change:

-	if (ssi_private->soc->imx)
+	if (!IS_ERR(ssi_private->clk))


More information about the Linuxppc-dev mailing list