[PATCH] powerpc: Add macros for the ibm_architecture_vec[] lengths

Stewart Smith stewart at linux.vnet.ibm.com
Tue Sep 9 11:03:03 EST 2014


Michael Ellerman <mpe at ellerman.id.au> writes:
> The encoding of the lengths in the ibm_architecture_vec array is
> "interesting" to say the least. It's non-obvious how the number of bytes
> we provide relates to the length value.
>
> In fact we already got it wrong once, see 11e9ed43ca8a "Fix up
> ibm_architecture_vec definition".
>
> So add some macros to make it (hopefully) clearer. These at least have
> the property that the integer present in the code is equal to the number
> of bytes that follows it.
>
> Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>

Seems at least as correct as the code was before... so,

Reviewed-by: Stewart Smith <stewart at linux.vnet.ibm.com>

(not actually compiled or tested or anything, but my internal C
preprocesser says it looks okay :)



More information about the Linuxppc-dev mailing list