[PATCH v8 3/7] clk: Move all drivers to use internal API

Ulf Hansson ulf.hansson at linaro.org
Tue Sep 2 17:13:14 EST 2014


On 1 September 2014 17:32, Tomeu Vizoso <tomeu.vizoso at collabora.com> wrote:
> In preparation to change the public API to return a per-user clk structure,
> remove any usage of this public API from the clock implementations.
>
> The reason for having this in a separate commit from the one that introduces
> the implementation of the new functions is to separate the changes generated
> with Coccinelle from the rest, and keep the patches' size reasonable.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>
> Tested-by: Boris Brezillon <boris.brezillon at free-electrons.com>
> Tested-by: Heiko Stuebner <heiko at sntech.de>
> Acked-by: Boris Brezillon <boris.brezillon at free-electrons.com>

Hi Tomeu,

Huh, what a patch. :-) Great work you are doing here!

By just looking at the ux500 changes, I realize that you now have
removed the dependency to "struct clk", thus we shouldn't include the
header file linux/clk.h in any file located in driver/clk/ux500/*,
right!?

I suppose this comment may also applicable for others than the ux500
clk driver, but haven't checked.

Kind regards
Uffe


More information about the Linuxppc-dev mailing list