[PATCH v2] CXL: Fix PSL error due to duplicate segment table entries
imunsie at au1.ibm.com
Tue Oct 28 14:25:26 AEDT 2014
In certain circumstances the PSL (Power Service Layer, which provides
translation services for CXL hardware) can send an interrupt for a segment miss
that the kernel has already handled. This can happen if multiple translations
for the same segment are queued in the PSL before the kernel has restarted the
The CXL driver does not expect this situation and does not check if a segment
had already been handled. This could cause a duplicate segment table entry
which in turn caused a PSL error taking down the card.
This patch series fixes the issue by checking for existing entries in the
segment table that match the segment it is trying to insert to avoid inserting
Some of the code has been refactored to simplify it - the segment table
hash has been moved from cxl_load_segment to find_free_sste where it is
used and we have disabled the secondary hash in the segment table to
reduce the number of entries that need to be tested from 16 to 8. Due to
the large segment sizes we use it is extremely unlikely that the
secondary hash would ever have been used in practice, so this should not
have any negative impacts and may even improve performance.
copro_calculate_slb didn't use the correct ESID mask for 1T vs 256M segments,
which was not a problem as the extra bits were ignored. This series fixes it to
use the correct mask to make debugging easier and so that we can directly
compare the ESID values for duplicates without needing to worry about masking
in the comparison.
- Patch 1 disables the secondary hash in the segment table to simplify the code.
- Patch 2 cleans up and refactors cxl_load_segment and find_free_sste to move
the hash calculation to where it is actually used.
- Patch 3 fixes the ESID returned by copro_calculate_slb to be properly masked
based on the segment size.
- Patch 4 prevents duplicate segment table entries from being inserted to fix
PSL errors resulting from this situation.
Changes since v1:
- Split patch out into separate patches for cleanups and bug fix
More information about the Linuxppc-dev