[PATCH 1/2] mm: Update generic gup implementation to handle hugepage directory

Aneesh Kumar K.V aneesh.kumar at linux.vnet.ibm.com
Fri Oct 17 05:05:10 AEDT 2014

Steve Capper <steve.capper at linaro.org> writes:

> Can we not just add a:
> #define pgd_huge(pgd)		(0)
> above the "#endif /* CONFIG_HUGETLB_PAGE */" line in the second patch?
> (or, more precisely, prevent the second patch from removing this line).
> That way we get a clearer code overall?

it is strange to have both pmd_huge and pud_huge in hugetlb.h and
pgd_huge in page.h. But if that is what we want then we may need.

diff --git a/arch/powerpc/include/asm/page.h b/arch/powerpc/include/asm/page.h
index aa430ec14895..aeca81947dc6 100644
--- a/arch/powerpc/include/asm/page.h
+++ b/arch/powerpc/include/asm/page.h
@@ -383,6 +383,7 @@ static inline int hugepd_ok(hugepd_t hpd)
 int pgd_huge(pgd_t pgd);
 #define is_hugepd(pdep)			0
+#define pgd_huge(pgd)			0
 #define __hugepd(x) ((hugepd_t) { (x) })

More information about the Linuxppc-dev mailing list