[PATCH v2] powerpc/powernv: Fallback to old HMI handling behavior for old firmware

Mahesh J Salgaonkar mahesh at linux.vnet.ibm.com
Sat Oct 11 02:58:26 AEDT 2014

From: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>

Recently we moved HMI handling into Linux kernel instead of taking
HMI directly in OPAL. This new change is dependent on new OPAL call
for HMI recovery which was introduced in newer firmware. While this new
change works fine with latest OPAL firmware, we broke the HMI handling
if we run newer kernel on old OPAL firmware that results in system hang.

This patch fixes this issue by falling back to old HMI behavior on older
OPAL firmware.

This patch introduces a check for opal token OPAL_HANDLE_HMI to see
if we are running on newer firmware or old firmware. On newer firmware
this check would return OPAL_TOKEN_PRESENT, otherwise we are running on
old firmware and fallback to old HMI behavior.

Old firmware: POWER8 System Firmware Release as of today <= SV810_087
Action: Let OPAL handle HMIs

Newer firmware: in development/yet to be released.
Action: Let Linux host handle HMIs.

This patch depends on opal check token patch posted at ppc-devel

Signed-off-by: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>
 arch/powerpc/platforms/powernv/opal.c |   23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
index b44eec3..f172c15 100644
--- a/arch/powerpc/platforms/powernv/opal.c
+++ b/arch/powerpc/platforms/powernv/opal.c
@@ -194,6 +194,29 @@ static int __init opal_register_exception_handlers(void)
 	 * fwnmi area at 0x7000 to provide the glue space to OPAL
 	glue = 0x7000;
+	/*
+	 * Check if we are running on newer firmware that exports
+	 * OPAL_HANDLE_HMI token. If yes, then don't ask opal to patch
+	 * HMI interrupt and we catch it directly in Linux kernel.
+	 *
+	 * For older firmware (i.e currently released POWER8 System Firmware
+	 * as of today <= SV810_087), we fallback to old behavior and let OPAL
+	 * to patch the HMI vector and handle it inside OPAL firmware.
+	 *
+	 * For newer firmware (in development/yet to be released) we will
+	 * start catching/handling HMI directly in Linux kernel.
+	 */
+	if (!opal_check_token(OPAL_HANDLE_HMI)) {
+		/* We are on old firmware. fallback to old behavior. */
+		pr_info("%s: Old firmware detected, let OPAL handle HMIs.\n",
+			"opal");
+		opal_register_exception_handler(
+				0, glue);
+		glue += 128;
+	}
 	opal_register_exception_handler(OPAL_SOFTPATCH_HANDLER, 0, glue);

More information about the Linuxppc-dev mailing list