[PATCH] [v2] power/fsl: add MDIO dt binding for FMan

[Shaohui Xie]

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Wednesday, November 26, 2014 9:50 AM
> To: shh.xie at gmail.com
> Cc: linuxppc-dev at lists.ozlabs.org; devicetree at vger.kernel.org; Medve
> Emilian-EMMEDVE1; Liberman Igal-B31950; Xie Shaohui-B21989
> Subject: Re: [PATCH] [v2] power/fsl: add MDIO dt binding for FMan
> 
> On Fri, 2014-11-14 at 17:53 +0800, shh.xie at gmail.com wrote:
> > From: Shaohui Xie <Shaohui.Xie at freescale.com>
> >
> > This binding is for FMan MDIO, it covers FMan v2 & FMan v3.
> >
> > Signed-off-by: Shaohui Xie <Shaohui.Xie at freescale.com>
> > ---
> > changes in V2:
> > addressed comments from Scott in V1.
> >
> >  .../devicetree/bindings/powerpc/fsl/fman.txt       | 69
> ++++++++++++++++++++++
> >  1 file changed, 69 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> > b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> > index edeea16..1523a87 100644
> > --- a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> > +++ b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> > @@ -7,6 +7,7 @@ CONTENTS
> >    - FMan MURAM Node
> >    - FMan dTSEC/XGEC/mEMAC Node
> >    - FMan IEEE 1588 Node
> > +  - FMan MDIO Node
> >    - Example
> >
> >
> > ======================================================================
> > ======= @@ -357,6 +358,68 @@ ptp-timer at fe000 {  };
> >
> >
> > ======================================================================
> > =======
> > +FMan MDIO Node
> > +
> > +DESCRIPTION
> > +
> > +The MDIO is a bus to which the PHY devices are connected.
> > +
> > +PROPERTIES
> > +
> > +- compatible
> > +		Usage: required
> > +		Value type: <stringlist>
> > +		Definition: A standard property.
> > +		Must include "fsl,fman-mdio" for 1 Gb/s MDIO from FMan v2.
> > +		Must include "fsl,fman-xmdio" for 10 Gb/s MDIO from FMan v2.
> > +		Must include "fsl,fman-memac-mdio" for 1/10 Gb/s MDIO from
> > +		FMan v3.
> > +
> > +- reg
> > +		Usage: required
> > +		Value type: <prop-encoded-array>
> > +		Definition: A standard property.
> > +
> > +- bus-frequency
> > +		Usage: optional
> > +		Value type: <u32>
> > +		Definition: Specifies external MDIO bus clock speed which is
> > +		different from MDIO standard 2.5MHz. Should be defined for
> SoCs
> > +		on which the standard one cannot work.
> > +
> > +- interrupts
> > +		Usage: optional
> > +		Value type: <prop-encoded-array>
> > +		Definition: Event interrupt of external MDIO controller.
> > +		1 Gb/s MDIO and 10 Gb/s MDIO has one interrupt respectively.
> > +
> > +- fsl,fman-internal-mdio
> > +		Usage: required for internal MDIO
> > +		Value type: boolean
> > +		Definition: Fman has internal MDIO for internal PCS(Physical
> > +		Coding Sublayer) PHYs and external MDIO for external PHYs.
> > +		The settings and programming routines for internal/external
> > +		MDIO are different. Must be included for internal MDIO.
> > +
> > +EXAMPLE
> > +
> > +Example for FMan v2 external MDIO:
> > +
> > +mdio at f1000 {
> > +	compatible = "fsl,fman-xmdio";
> > +	reg = <0xf1000 0x1000>;
> > +	bus-frequency = <20000>;
> > +};
> 
> So the bus frequency is only 20 KHz?  Or is the unit supposed to be
> something other than Hz?
[S.H] it's only an example, it could be different on real SoCs, but they always lower than the standard one,
The standard one is 2.5MHz, I have to use Hz for it.

Thanks!
Shaohui