[PATCH] powerpc/powernv: Support OPAL requested heartbeat
Alistair Popple
alistair at popple.id.au
Fri Nov 14 14:01:50 AEDT 2014
Hi Ben,
On Wed, 12 Nov 2014 17:03:14 Benjamin Herrenschmidt wrote:
<snip>
> +
> +static int kopald(void *unused)
> +{
> + set_freezable();
> + do {
> + try_to_freeze();
> + opal_poll_events(NULL);
Do we need to check for outstanding events (and call opal_do_notifier)? The
Linux OPAL-IPMI interface signals an event which the interrupt handler
(opal_interrupt) checks for, but if interrupts aren't functional no event will
be signalled and hence the Linux IPMI layer won't get a response.
It's probably only an issue for lab bring up though as I would expect
interrupts to generally be working...
> + msleep_interruptible(opal_heartbeat);
> + } while (!kthread_should_stop());
> +
> + return 0;
> +}
> +
Regards,
Alistair
More information about the Linuxppc-dev
mailing list