[PATCH v2] PPC: bpf_jit_comp: add SKF_AD_PKTTYPE instruction

Alexei Starovoitov alexei.starovoitov at gmail.com
Tue Nov 4 04:21:03 AEDT 2014


On Mon, Nov 3, 2014 at 9:06 AM, David Miller <davem at davemloft.net> wrote:
> From: Denis Kirjanov <kda at linux-powerpc.org>
> Date: Thu, 30 Oct 2014 09:12:15 +0300
>
>> Add BPF extension SKF_AD_PKTTYPE to ppc JIT to load
>> skb->pkt_type field.
>>
>> Before:
>> [   88.262622] test_bpf: #11 LD_IND_NET 86 97 99 PASS
>> [   88.265740] test_bpf: #12 LD_PKTTYPE 109 107 PASS
>>
>> After:
>> [   80.605964] test_bpf: #11 LD_IND_NET 44 40 39 PASS
>> [   80.607370] test_bpf: #12 LD_PKTTYPE 9 9 PASS
>>
>> CC: Alexei Starovoitov<alexei.starovoitov at gmail.com>
>> CC: Michael Ellerman<mpe at ellerman.id.au>
>> Cc: Matt Evans <matt at ozlabs.org>
>> Signed-off-by: Denis Kirjanov <kda at linux-powerpc.org>
>>
>> v2: Added test rusults
>
> So, can I apply this now?

I think this question is more towards ppc folks,
since both Daniel and myself said before that it looks ok.
Philippe just tested the previous version of this patch on ppc64le...
I'm guessing that Matt (original author of bpf jit for ppc) is not replying,
because he has no objections.
Either way the addition is tiny and contained, so can go in now.


More information about the Linuxppc-dev mailing list