[PATCH] powerpc/perf/hv-24x7: use kmem_cache instead of aligned stack allocations

Stephen Rothwell sfr at canb.auug.org.au
Fri May 23 08:38:47 EST 2014


Hi Cody,

On Thu, 22 May 2014 15:29:08 -0700 Cody P Schafer <cody at linux.vnet.ibm.com> wrote:
>
> -	*res = be64_to_cpu(result_buffer.result);
> +	*res = be64_to_cpu(result_buffer->result);
> +	kfree(result_buffer);
> +	kfree(request_buffer);
> +	return ret;

Why not just fall through here by removing the above 3 lines?

> +
> +out_hcall:
> +	kfree(result_buffer);
> +out_resb:
> +	kfree(request_buffer);
> +out_reqb:
>  	return ret;
>  }

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20140523/1ab6eeff/attachment.sig>


More information about the Linuxppc-dev mailing list