[6/6] powerpc/mpic: Remove duplicate MPIC_WANTS_RESET flag

Scott Wood scottwood at freescale.com
Wed May 21 11:23:01 EST 2014

On Thu, Dec 22, 2011 at 03:19:14PM -0500, Kyle Moffett wrote:
> There are two separate flags controlling whether or not the MPIC is
> reset during initialization, which is completely unnecessary, and only
> one of them can be specified in the device tree.

Those flags didn't actually do exactly the same thing.  MPIC_WANTS_RESET
controlled whether Linux pushes the big MPIC reset bit.  MPIC_NO_RESET
did inhibit that before, but it also inhibited resetting individual
sources.  By turning on MPIC_NO_RESET on boards that didn't have it,
these sources are now being left in whatever state the bootloader left
them in, which is not desireable outside of special cases like AMP.

This also ended up hiding a bug in the Freescale MPIC error interrupt
support, where the cascade was being registered prior to the reset.

Martyn, I see you set MPIC_NO_RESET in ge_imp3a.c -- was this just
copy+paste or is there a reason to leave this enabled on that board?


More information about the Linuxppc-dev mailing list