[PATCH] powerpc/powernv: Fix build error when CONFIG_SMP=n

Shreyas B. Prabhu shreyas at linux.vnet.ibm.com
Tue May 20 19:55:26 EST 2014


Fix the following build error when compiled with CONFIG_SMP=n
arch/powerpc/platforms/powernv/setup.c: In function ‘pnv_kexec_wait_secondaries_down’:
arch/powerpc/platforms/powernv/setup.c:179:4: error: implicit declaration of function ‘get_hard_smp_processor_id’ [-Werror=implicit-function-declaration]
    rc = opal_query_cpu_status(get_hard_smp_processor_id(i),

The usage of get_hard_smp_processor_id() needs the declaration from <asm/smp.h>.
The file setup.c includes <linux/sched.h>, which in-turn includes <linux/smp.h>.
However, <linux/smp.h> includes <asm/smp.h> only on SMP configs and hence UP
builds fail. Fix this by directly including <asm/smp.h> in setup.c
unconditionally.

Reported-by: Geert Uytterhoeven <geert at linux-m68k.org>
Signed-off-by: Shreyas B. Prabhu <shreyas at linux.vnet.ibm.com>
---
 arch/powerpc/platforms/powernv/setup.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/platforms/powernv/setup.c b/arch/powerpc/platforms/powernv/setup.c
index 8723d32..e6bde98 100644
--- a/arch/powerpc/platforms/powernv/setup.c
+++ b/arch/powerpc/platforms/powernv/setup.c
@@ -34,6 +34,7 @@
 #include <asm/rtas.h>
 #include <asm/opal.h>
 #include <asm/kexec.h>
+#include <asm/smp.h>
 
 #include "powernv.h"
 
-- 
1.9.0



More information about the Linuxppc-dev mailing list