[tip:irq/core] powerpc: eeh: Fixup the brown paperbag fallout of the "cleanup"

tip-bot for Thomas Gleixner tipbot at zytor.com
Wed Mar 5 10:15:51 EST 2014


Commit-ID:  57310c3c99eb6fab2ecbd63aa3f7c323341ca77e
Gitweb:     http://git.kernel.org/tip/57310c3c99eb6fab2ecbd63aa3f7c323341ca77e
Author:     Thomas Gleixner <tglx at linutronix.de>
AuthorDate: Wed, 5 Mar 2014 00:06:11 +0100
Committer:  Thomas Gleixner <tglx at linutronix.de>
CommitDate: Wed, 5 Mar 2014 00:13:33 +0100

powerpc: eeh: Fixup the brown paperbag fallout of the "cleanup"

Commit b8a9a11b9 (powerpc: eeh: Kill another abuse of irq_desc) is
missing some brackets .....

It's not a good idea to write patches in grumpy mode and then forget
to at least compile test them or rely on the few eyeballs discussing
that patch to spot it.....

Reported-by: fengguang.wu at intel.com
Signed-off-by: Thomas Gleixner <tglx at linutronix.de>
Cc: Peter Zijlstra <peterz at infradead.org>
Cc: Gavin Shan <shangw at linux.vnet.ibm.com>
Cc: Benjamin Herrenschmidt <benh at kernel.crashing.org>
Cc: ppc <linuxppc-dev at lists.ozlabs.org>
---
 arch/powerpc/kernel/eeh_driver.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/eeh_driver.c b/arch/powerpc/kernel/eeh_driver.c
index 3e1d7de..bb61ca5 100644
--- a/arch/powerpc/kernel/eeh_driver.c
+++ b/arch/powerpc/kernel/eeh_driver.c
@@ -166,8 +166,9 @@ static void eeh_enable_irq(struct pci_dev *dev)
 		 *
 		 *	tglx
 		 */
-		if (irqd_irq_disabled(irq_get_irq_data(dev->irq))
+		if (irqd_irq_disabled(irq_get_irq_data(dev->irq)))
 			enable_irq(dev->irq);
+	}
 }
 
 /**


More information about the Linuxppc-dev mailing list