[PATCH tty-next 14/22] tty: Remove tty_wait_until_sent_from_close()

One Thousand Gnomes gnomes at lxorguk.ukuu.org.uk
Tue Jun 17 21:54:41 EST 2014


> Before the patch, I believe tty_reopen() would return -EIO because
> the TTY_CLOSING flag is set. After the patch, tty_open() blocks
> on tty_lock() before calling tty_reopen(). AFAICT, this is independent
> of O_NONBLOCK.

That would be a bug then. Returning -EIO is fine (if unfriendly). The
O_NONBLOCK can't block in this case though because the port could take a
long time to give up trying to dribble its bits (up to 30 seconds or so)

Alan



More information about the Linuxppc-dev mailing list