[PATCH 0/4] remap non-modular uses of module_init properly

Paul Gortmaker paul.gortmaker at windriver.com
Tue Jan 14 03:21:49 EST 2014

The goal is to move module_init/module_exit from init.h and into
module.h -- however in doing so, we uncover several instances in
powerpc code where module_init is used somewhat incorrectly by
non modular code, and a file that needs module.h but isn't sourcing
it.  We need to make these fixups 1st before changing the headers
so that we don't cause build failures.

The changes are largely inert, however we do cause a largely trivial
change in the initcall ordering -- that happens because module_init
is really device_initcall; and yet we shouldn't be using device_initcall
where clearly arch_initcall or subsys_initcall are more appropriate.

Boot tested on sbc8548 on powerpc next branch of today.

Paul Gortmaker (4):
  powerpc: use device_initcall for registering rtc devices
  powerpc: book3s kvm can be modular so it should use module.h
  powerpc: use subsys_initcall for Freescale Local Bus
  powerpc: don't use module_init for non-modular core hugetlb code

 arch/powerpc/kernel/time.c        | 2 +-
 arch/powerpc/kvm/book3s.c         | 2 +-
 arch/powerpc/mm/hugetlbpage.c     | 2 +-
 arch/powerpc/platforms/ps3/time.c | 3 +--
 arch/powerpc/sysdev/fsl_lbc.c     | 2 +-
 5 files changed, 5 insertions(+), 6 deletions(-)


More information about the Linuxppc-dev mailing list