[RFC] linux/pci: move pci_platform_pm_ops to linux/pci.h

Dongsheng.Wang at freescale.com Dongsheng.Wang at freescale.com
Tue Jan 7 20:35:16 EST 2014



> -----Original Message-----
> From: Rafael J. Wysocki [mailto:rjw at rjwysocki.net]
> Sent: Monday, January 06, 2014 8:13 PM
> To: Bjorn Helgaas
> Cc: Wang Dongsheng-B40534; Zang Roy-R61911; Wood Scott-B07421; Kumar Gala; Linux
> PM list; linux-pci at vger.kernel.org; linuxppc-dev
> Subject: Re: [RFC] linux/pci: move pci_platform_pm_ops to linux/pci.h
> 
> On Friday, December 20, 2013 09:42:59 AM Bjorn Helgaas wrote:
> > On Fri, Dec 20, 2013 at 3:03 AM, Dongsheng Wang
> > <dongsheng.wang at freescale.com> wrote:
> > > From: Wang Dongsheng <dongsheng.wang at freescale.com>
> > >
> > > make Freescale platform use pci_platform_pm_ops struct.
> >
> > This changelog doesn't say anything about what the patch does.
> >
> > I infer that you want to use pci_platform_pm_ops from some Freescale
> > code.  This patch should be posted along with the patches that add
> > that Freescale code, so we can see how you intend to use it.
> >
> > The existing use is in drivers/pci/pci-acpi.c, so it's possible that
> > your new use should be added in the same way, in drivers/pci, so we
> > don't have to make pci_platform_pm_ops part of the public PCI
> > interface in include/linux/pci.h.
> >
> > That said, if Raphael thinks this makes sense, it's OK with me.
> 
> Well, I'd like to know why exactly the change is needed in the first place.
> 
Thanks for review, I think the idea is not suitable for freescale platform
implementation of the right now.

I will drop this RFC patch.

-Dongsheng

> Thanks!
> 
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.
> 



More information about the Linuxppc-dev mailing list