[11/12,v3] pci: fsl: update PCI EDAC driver
Lian Minghuan-b31939
b31939 at freescale.com
Mon Jan 6 14:57:53 EST 2014
Hi Scott,
I think we should reverse this commit
0f1741c74aa6794b1c7fbdd19f26a4f2377a11c6.
PCI controller driver is a platform driver supports probe and remove,
when removing the driver we should call mpc85xx_pci_err_remove() to free EDAC PCI resource.
Thanks,
Minghuan
On 01/04/2014 06:16 AM, Scott Wood wrote:
> On Wed, Oct 23, 2013 at 06:41:33PM +0800, Minghuan Lian wrote:
>> diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c
>> index 40d2e1d..4a03e1a 100644
>> --- a/arch/powerpc/sysdev/fsl_pci.c
>> +++ b/arch/powerpc/sysdev/fsl_pci.c
>> @@ -236,6 +236,7 @@ void fsl_arch_pci_sys_remove(struct fsl_pci *pci)
>> if (!hose)
>> return;
>>
>> + mpc85xx_pci_err_remove(to_platform_device(pci->dev));
>> pcibios_free_controller(hose);
> This causes a linker error if the EDAC driver is enabled, due to commit
> 0f1741c74aa6794b1c7fbdd19f26a4f2377a11c6 ("edac/85xx: Remove
> mpc85xx_pci_err_remove").
>
> -Scott
More information about the Linuxppc-dev
mailing list