[PATCH v2] powernv: don't attempt to refetch the FSP dump until the user has explicitly acked it.

Stewart Smith stewart at linux.vnet.ibm.com
Fri Feb 21 14:34:36 EST 2014


Michael Neuling <mikey at neuling.org> writes:
> Stewart Smith <stewart at linux.vnet.ibm.com> wrote:
>
>> This fixes a bug where we would get two events from OPAL with DUMP_AVAIL
>> set (which is valid for OPAL to do) and in the second run of extract_dump()
>> we would fail to free the memory previously allocated for the dump
>> (leaking ~6MB+) as well as on the second dump_read_data() call OPAL
>> would not retrieve the dump, leaving us with a dump in linux that was
>> the correct size but all zeros.
>> 
>> Changes since v1: fixed typo
>> 
>> Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
>> Acked-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
>
> Should we CC stable on this?

we don't need to as the code this patches hasn't made it to stable
yet. Hopefully Vasant resends a version of the patch incorporating my
fix :)



More information about the Linuxppc-dev mailing list