[PATCH 2/2] of: search the best compatible match first in __of_match_node()

[Kumar Gala]

On Feb 14, 2014, at 9:53 AM, Rob Herring <robherring2 at gmail.com> wrote:

> On Thu, Feb 13, 2014 at 11:22 PM, Kevin Hao <haokexin at gmail.com> wrote:
>> Currently, of_match_node compares each given match against all node's
>> compatible strings with of_device_is_compatible.
>> 
>> To achieve multiple compatible strings per node with ordering from
>> specific to generic, this requires given matches to be ordered from
>> specific to generic. For most of the drivers this is not true and also
>> an alphabetical ordering is more sane there.
>> 
>> Therefore, this patch introduces a function to match each of the node's
>> compatible strings against all given compatible matches without type and
>> name first, before checking the next compatible string. This implies
>> that node's compatibles are ordered from specific to generic while
>> given matches can be in any order. If we fail to find such a match
>> entry, then fall-back to the old method in order to keep compatibility.
>> 
>> Cc: Sebastian Hesselbarth <sebastian.hesselbarth at gmail.com>
>> Signed-off-by: Kevin Hao <haokexin at gmail.com>
> 
> Looks good to me. I'll put this in next for a few days. I'd really
> like to see some acks and tested-by's before sending to Linus.
> 
> We could be a bit more strict here and fallback to the old matching if
> the match table has any entries with name or type. I don't think that
> should be necessary though.
> 
> Rob
> 


Can you push the revert to Linus sooner, since currently a ton of boards wouldn’t be working on the PPC side, so at least -rc3 has the possibility of working for them.

- k