[PATCH 2/2] clocksource: Make clocksource register functions void

Thomas Gleixner tglx at linutronix.de
Thu Feb 6 07:39:33 EST 2014

On Thu, 23 Jan 2014, Daniel Lezcano wrote:
> On 01/23/2014 08:12 AM, Yijing Wang wrote:
> > Currently, clocksource_register() and __clocksource_register_scale()
> > functions always return 0, it's pointless, make functions void.
> > And remove the dead code that check the clocksource_register_hz()
> > return value.
> > 
> > Signed-off-by: Yijing Wang <wangyijing at huawei.com>
> Well, do we really want to change all these files to not take care of a return
> value ? What about is we have to check it again later ?
> I would recommend to investigate __clocksource_register_scale and the
> underneath functions if there is not an error to be returned in the call stack
> somewhere which is ignored today.
> The same applies for clocksource_register.

There is really no point in making it fail. It's so low level that
anything more than a proper printk/BUG/WARN is overkill.



More information about the Linuxppc-dev mailing list