[PATCH] misc: cxl: sysfs.c: Remove unused function

Michael Ellerman mpe at ellerman.id.au
Mon Dec 22 14:55:54 AEDT 2014


On Sun, 2014-12-21 at 13:46 +0100, Rickard Strandqvist wrote:
> 2014-12-21 5:05 GMT+01:00 Michael Neuling <mikey at neuling.org>:
> >> Remove the function mmio_size_show() that is not used anywhere.
> >
> > Did you compile check this patch?
> >
> >   drivers/misc/cxl/sysfs.c:291:74: error: ‘mmio_size_show’ undeclared here (not in a function)
> >
> > It's used here:
> >         static struct device_attribute afu_attrs[] = {
> >                 __ATTR_RO(mmio_size),
> 
> Hi
> 
> Sorry about that.
> 
> Strange because I compile everything as allyesconfig, allmodconfig and
> allnoconfig.

The allyes should have picked it up, so you must have done something wrong.

Please be more careful with these attribute routines, they are not visible with
grep.

cheers




More information about the Linuxppc-dev mailing list