[PATCH] powerpc/kernel: Make syscall_exit a local label
Michael Ellerman
mpe at ellerman.id.au
Mon Dec 15 14:03:21 AEDT 2014
On Fri, 2014-12-05 at 10:27 +0000, David Laight wrote:
> From: Michael Ellerman
> > diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S
> > index 0905c8da90f1..d8828e50dbef 100644
> > --- a/arch/powerpc/kernel/entry_64.S
> > +++ b/arch/powerpc/kernel/entry_64.S
> > @@ -178,7 +178,7 @@ system_call: /* label this so stack traces look sane */
> > mtctr r12
> > bctrl /* Call handler */
>
> Why not add a 'nop' here instead?
Because we'd rather not add extra instructions to the syscall path unless we
really need to. A local label seems like the preferable solution to me.
cheers
More information about the Linuxppc-dev
mailing list