[RFC PATCH 8/8] perf probe powerpc: Fixup function entry if using kallsyms lookup

Naveen N. Rao naveen.n.rao at linux.vnet.ibm.com
Wed Dec 10 04:34:06 AEDT 2014


On powerpc ABIv2, if no debug-info is found and we use kallsyms,
we need to fixup the function entry to point to the local entry point.
Use offset of 8 since current toolchains always generate 2
instructions (8 bytes).

Signed-off-by: Naveen N. Rao <naveen.n.rao at linux.vnet.ibm.com>
---
 tools/perf/util/probe-event.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index adcdbd2..0970e2a 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -2318,6 +2318,15 @@ static int find_probe_trace_events_from_map(struct perf_probe_event *pev,
 		}
 		/* Add one probe point */
 		tp->address = map->unmap_ip(map, sym->start) + pp->offset;
+#if defined(__powerpc64__) && defined(_CALL_ELF) && _CALL_ELF == 2
+		/*
+		 * If we used kallsyms, we should fixup the function entry address here.
+		 * ppc64le ABIv2 local entry point is currently always 2 instructions (8 bytes)
+		 * after the global entry point. Fix this if it ever changes.
+		 */
+		if (!pev->uprobes && map->dso->symtab_type == DSO_BINARY_TYPE__KALLSYMS)
+			tp->address += 8;
+#endif
 		if (reloc_sym) {
 			tp->symbol = strdup_or_goto(reloc_sym->name, nomem_out);
 			tp->offset = tp->address - reloc_sym->addr;
-- 
2.1.3



More information about the Linuxppc-dev mailing list