[RFC PATCH v2 1/1] powerpc/85xx: Add support for Emerson/Artesyn MVME2500.

[Alessio Igor Bogani]

Hi Scott,

On 4 December 2014 at 21:16, Scott Wood <scottwood at freescale.com> wrote:
> On Thu, 2014-12-04 at 10:23 +0100, Alessio Igor Bogani wrote:
>> +/include/ "fsl/pq3-mpic-message-B.dtsi"
>
> The MPIC message include should be done in the SoC file -- it's not
> board-specific.
>
> For some reason I don't see this dtsi being included by anything
> currently.

For the moment I'll remove it.

>> @@ -80,33 +82,21 @@ CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
>>  CONFIG_DEVTMPFS=y
>>  CONFIG_DEVTMPFS_MOUNT=y
>>  CONFIG_MTD=y
>> -CONFIG_MTD_OF_PARTS=y
>>  CONFIG_MTD_CMDLINE_PARTS=y
>> -CONFIG_MTD_CHAR=y
>> -CONFIG_MTD_BLKDEVS=y
>>  CONFIG_MTD_BLOCK=y
>>  CONFIG_FTL=y
>>  CONFIG_MTD_CFI=y
>> -CONFIG_MTD_GEN_PROBE=y
>> -CONFIG_MTD_MAP_BANK_WIDTH_1=y
>> -CONFIG_MTD_MAP_BANK_WIDTH_2=y
>> -CONFIG_MTD_MAP_BANK_WIDTH_4=y
>> -CONFIG_MTD_CFI_I1=y
>> -CONFIG_MTD_CFI_I2=y
>
> Are these removals due to make savedefconfig?

Yes

> Please have a separate
> patch that just runs make savedefconfig first, so that we can see what
> actual changes are being made.

Sure!

> Otherwise, looks good.

Thanks!

Ciao,
Alessio