[PATCH v2] powerpc: Remove more traces of bootmem

Michael Ellerman mpe at ellerman.id.au
Wed Dec 3 10:43:09 AEDT 2014


On Thu, 2014-11-20 at 13:33 +1100, Tony Breeds wrote:
> On Thu, Nov 20, 2014 at 11:07:38AM +1100, Michael Ellerman wrote:
> > --- a/arch/powerpc/lib/alloc.c
> > +++ b/arch/powerpc/lib/alloc.c
> > @@ -13,9 +13,7 @@ void * __init_refok zalloc_maybe_bootmem(size_t size, gfp_t mask)
> >  	if (mem_init_done)
> >  		p = kzalloc(size, mask);
> >  	else {
> > -		p = alloc_bootmem(size);
> > -		if (p)
> > -			memset(p, 0, size);
> > +		p = memblock_virt_alloc(size, 0);
> >  	}
> 
> You knew someone would ask but ...
> Do you want to remove the {} form the else clause so that the style matches the  if()

Actually I was going to do a follow-up that just returns directly without p at
all, thanks for the reminder :)

cheers





More information about the Linuxppc-dev mailing list