[PATCH] i2c: mpc: add register documentation to Freescale I2C driver

Wolfram Sang wsa at the-dreams.de
Tue Dec 2 04:21:47 AEDT 2014


On Sat, Nov 29, 2014 at 01:58:42PM -0800, Danielle Costantino wrote:
> i2c: mpc: add register documentation to Freescale I2C driver

This should be in one patch.

> 
> return -ETIMEDOUT for all time-out error conditions

This should be in a seperate patch.

> and warn on arbitration lost.

And this should be dropped. "Arbitration lost" lost is not an error, it
is specified behaviour of I2C.

>      if (!(cmd_err & CSR_MCF)) {
> -        dev_dbg(i2c->dev, "unfinished\n");
> +        dev_warn(i2c->dev, "unfinished\n");

Are you sure this helps a regular user?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20141201/4539518a/attachment.sig>


More information about the Linuxppc-dev mailing list