[PATCH 4/4] powerpc: Move htab_remove_mapping function prototype into header file

Stephen Rothwell sfr at canb.auug.org.au
Sat Aug 23 01:29:40 EST 2014


Hi Anton,

On Wed, 20 Aug 2014 08:55:21 +1000 Anton Blanchard <anton at samba.org> wrote:
>
> A recent patch added a function prototype for htab_remove_mapping in
> c code. Fix it.
> 
> Signed-off-by: Anton Blanchard <anton at samba.org>
> ---
>  arch/powerpc/include/asm/mmu-hash64.h | 2 ++
>  arch/powerpc/mm/init_64.c             | 3 ---
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/powerpc/include/asm/mmu-hash64.h b/arch/powerpc/include/asm/mmu-hash64.h
> index d765144..92bc3a6 100644
> --- a/arch/powerpc/include/asm/mmu-hash64.h
> +++ b/arch/powerpc/include/asm/mmu-hash64.h
> @@ -342,6 +342,8 @@ extern void hash_failure_debug(unsigned long ea, unsigned long access,
>  extern int htab_bolt_mapping(unsigned long vstart, unsigned long vend,
>  			     unsigned long pstart, unsigned long prot,
>  			     int psize, int ssize);
> +int htab_remove_mapping(unsigned long vstart, unsigned long vend,
> +			int psize, int ssize);

Please be consistent about "extern" use (unless this file is already
inconsistent, I guess).  (I know that the current trend is to remove
"extern" in header files - I just happen to disagree with that
trend. :-))

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20140823/7ebefeac/attachment.sig>


More information about the Linuxppc-dev mailing list