[PATCH v2] PC, KVM, CMA: Fix regression caused by wrong get_order() use

Alexey Kardashevskiy aik at ozlabs.ru
Fri Aug 15 13:00:43 EST 2014


On 08/14/2014 11:40 PM, Alexander Graf wrote:
> 
> On 14.08.14 07:13, Aneesh Kumar K.V wrote:
>> Alexey Kardashevskiy <aik at ozlabs.ru> writes:
>>
>>> fc95ca7284bc54953165cba76c3228bd2cdb9591 claims that there is no
>>> functional change but this is not true as it calls get_order() (which
>>> takes bytes) where it should have called ilog2() and the kernel stops
>>> on VM_BUG_ON().
>>>
>>> This replaces get_order() with order_base_2() (round-up version of ilog2).
>>>
>>> Suggested-by: Paul Mackerras <paulus at samba.org>
>>> Cc: Alexander Graf <agraf at suse.de>
>>> Cc: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
>>> Cc: Joonsoo Kim <iamjoonsoo.kim at lge.com>
>>> Cc: Benjamin Herrenschmidt <benh at kernel.crashing.org>
>>> Signed-off-by: Alexey Kardashevskiy <aik at ozlabs.ru>
>> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
> 
> So this affects 3.17?

Yes.


-- 
Alexey


More information about the Linuxppc-dev mailing list