qe: move qe from arch/powerpc to drivers

Scott Wood scottwood at freescale.com
Fri Aug 8 03:15:05 EST 2014


On Thu, 2014-08-07 at 04:15 -0500, Zhao Qiang-B45475 wrote:
> On Thu, Aug 7, 2014 at 4:16 AM, Wood Scott wrote:
> 
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Thursday, August 07, 2014 4:16 AM
> > To: Zhao Qiang-B45475
> > Cc: linuxppc-dev at lists.ozlabs.org; Xie Xiaobo-R63061
> > Subject: Re: qe: move qe from arch/powerpc to drivers
> > 
> > On Wed, 2014-08-06 at 03:53 -0500, Zhao Qiang-B45475 wrote:
> > > On Wed, Jul 30, 2014 at 08:19 AM, Wood Scott wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: Wood Scott-B07421
> > > > Sent: Wednesday, July 30, 2014 8:19 AM
> > > > To: Zhao Qiang-B45475
> > > > Cc: linuxppc-dev at lists.ozlabs.org; Wood Scott-B07421; Xie
> > > > Xiaobo-R63061
> > > > Subject: Re: qe: move qe from arch/powerpc to drivers
> > > >
> > > > On Tue, Jun 24, 2014 at 11:31:52AM +0800, Zhao Qiang wrote:
> > > > > ls1 has qe and ls1 has arm cpu.
> > > > > move qe from arch/powerpc to drivers.
> > > > >
> > > > > Signed-off-by: Zhao Qiang <B45475 at freescale.com>
> > > >
> > > > This is a very terse changelog.  Explain more about what QE is, and
> > > > what this patch accomplishes (it doesn't seem to get rid of the PPC
> > > > dependency, just moving code at this stage)
> > > >
> > > > I don't see a MAINTAINERS update for the new path.  Who is going to
> > > > maintain it?
> > > >
> > > > I don't think drivers/qe is the right place for it.  Directories
> > > > directly under drivers/ tend to be for classes of devices, not
> > > > instances.  In any case, LKML should be CCed when creating a new
> > > > directory directly under drivers/ or under a subdirectory of
> > > > drivers/ that doesn't have its own mailing list.
> > >
> > > So which directory do you recommend?
> > 
> > drivers/soc/
> > 
> > > Actually qe is a kind of IP block, so in my opinion, it is proper to
> > put it under driver/(just in my opinion).
> > 
> > No, it isn't a type of device (e.g. "ethernet" or "tty").  It's an
> > abbreviation of a trademark for a specific multipurpose I/O architecture.
> 
> So which directory do you recommend?

Please see about 10 lines up. :-P

-Scott




More information about the Linuxppc-dev mailing list