[PATCH] powerpc/p1010rdb:update dts to adapt to both old and new p1010rdb

Zhao Qiang-B45475 B45475 at freescale.com
Sun Sep 29 12:29:56 EST 2013


On Sat, 2013-09-28 at 5:35 AM, Scott wrote:

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Saturday, September 28, 2013 5:35 AM
> To: Zhao Qiang-B45475
> Cc: linuxppc-dev at lists.ozlabs.org; Liu Shengzhou-B36685
> Subject: Re: [PATCH] powerpc/p1010rdb:update dts to adapt to both old and
> new p1010rdb
> 
> On Sun, 2013-09-22 at 10:28 +0800, Zhao Qiang wrote:
> > P1010rdb-pa and p1010rdb-pb have different phy interrupts.
> > So update dts to adapt to both p1010rdb-pa and p1010rdb-pb.
> >
> > Signed-off-by: Shengzhou Liu <Shengzhou.Liu at freescale.com>
> > Signed-off-by: Zhao Qiang <B45475 at freescale.com>
> > ---
> >  arch/powerpc/boot/dts/p1010rdb-pa.dts | 33 ++++++++++++++++++
> > arch/powerpc/boot/dts/p1010rdb-pb.dts | 33 ++++++++++++++++++
> >  arch/powerpc/boot/dts/p1010rdb.dts    | 66 ---------------------------
> --------
> >  arch/powerpc/boot/dts/p1010rdb.dtsi   | 51 ++++++++++++++++++++++++---
> >  4 files changed, 112 insertions(+), 71 deletions(-)  create mode
> > 100644 arch/powerpc/boot/dts/p1010rdb-pa.dts
> >  create mode 100644 arch/powerpc/boot/dts/p1010rdb-pb.dts
> >  delete mode 100644 arch/powerpc/boot/dts/p1010rdb.dts
> 
> What about p1010rdb_36b.dts?
> 
> -Scott
> 

Yes, we really need to take 36b into account.
Now, there is another problem to be discussed.
If we just add files p1010rdb-pb.dts and p1010rdb-pb_36b.dts, there will be some redundant codes.
If we want to avoid this situation, we need to add two more dtsi files.
Less codes or less files, which one do you like better?

-Zhao Qiang


More information about the Linuxppc-dev mailing list