[PATCH v2 1/2] powerpc/85xx: introduce corenet_generic machine

[Kevin Hao]

On Mon, Sep 23, 2013 at 05:33:58PM -0500, Scott Wood wrote:
> On Sun, 2013-09-22 at 15:42 +0800, Kevin Hao wrote:
> > In the current kernel, the board files for p2041rdb, p3041ds, p4080ds,
> > p5020ds, p5040ds, t4240qds and b4qds are almost the same except the
> > machine name. So this introduces a cornet_generic machine to support
> > all these boards to avoid the code duplication.
> > 
> > With these changes the file corenet_ds.h becomes useless. Just delete
> > it.
> > 
> > Signed-off-by: Kevin Hao <haokexin at gmail.com>
> > ---
> > v2:
> >   - Fix the typo in subject.
> >   - Fold the original patch 2 into this one.
> >   - Change the machine name from "CORENET GENERIC" to "CORENET Generic".
> 
> CoreNet shouldn't be allcaps either.

OK. Will change it to "CoreNet Generic".

> 
> > diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig
> > index de2eb93..3bee943 100644
> > --- a/arch/powerpc/platforms/85xx/Kconfig
> > +++ b/arch/powerpc/platforms/85xx/Kconfig
> > @@ -228,6 +228,7 @@ config P2041_RDB
> >  	select GPIO_MPC8XXX
> >  	select HAS_RAPIDIO
> >  	select PPC_EPAPR_HV_PIC
> > +	select CORENET_GENERIC
> >  	help
> >  	  This option enables support for the P2041 RDB board
> >  
> > @@ -241,6 +242,7 @@ config P3041_DS
> >  	select GPIO_MPC8XXX
> >  	select HAS_RAPIDIO
> >  	select PPC_EPAPR_HV_PIC
> > +	select CORENET_GENERIC
> >  	help
> >  	  This option enables support for the P3041 DS board
> >  
> > @@ -254,6 +256,7 @@ config P4080_DS
> >  	select GPIO_MPC8XXX
> >  	select HAS_RAPIDIO
> >  	select PPC_EPAPR_HV_PIC
> > +	select CORENET_GENERIC
> >  	help
> >  	  This option enables support for the P4080 DS board
> 
> As discussed earlier, I'd prefer if this were combined into one kconfig
> option.  The help text can list boards that are known to work with it.

OK, will do.

Thanks,
Kevin
> 
> -Scott
> 
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20130924/ed92eb8f/attachment.sig>