[PATCH 1/2][v3] powerpc/fsl-booke: Add initial T104x_QDS board support

Scott Wood scottwood at freescale.com
Tue Sep 24 04:06:30 EST 2013


On Fri, 2013-09-20 at 19:23 -0500, Timur Tabi wrote:
> Scott Wood wrote:
> > The patch is not "lying".  It is describing the board, not what the
> > patch supports.  This was something you used to constantly tell people
> > to do...
> 
> The patch says:
> 
> 	"DIU supports video at up to 1280x1024x32bpp"
> 
> How is this not misleading?

Does it have different limits on this board?

> I understand that the patch describes the board, and that's correct.  It 
> should also indicate which major functionality is not supported.  I was 
> expecting something like this:
> 
> - Video
>       - DIU hardware is capable of video up to 1280x1024x32bpp
>       - DIU support is currently not implemented

Sure, it would be nice to point out notable limitations in the board
support.  That doesn't mean that it's lying as is, as it's quite
obviously a cut and paste from some other document rather than a
meaningful description of the patch itself.  I've never been a fan of
this sort of changelog, as we've discussed in the past.

-Scott





More information about the Linuxppc-dev mailing list