[PATCH] powerpc/p1010rdb:remove interrupts of ethernet-phy in device tree

[Zhao Qiang-B45475]

On Sep 13, 2013, at 12:42 AM, Kumar Gala wrote:

> -----Original Message-----
> From: Kumar Gala [mailto:galak at kernel.crashing.org]
> Sent: Friday, September 13, 2013 12:42 AM
> To: Liu Shengzhou-B36685
> Cc: Zhao Qiang-B45475; linuxppc-dev at lists.ozlabs.org
> Subject: Re: [PATCH] powerpc/p1010rdb:remove interrupts of ethernet-phy
> in device tree
> 
> 
> On Sep 12, 2013, at 1:54 AM, Liu Shengzhou-B36685 wrote:
> 
> >
> >
> >> -----Original Message-----
> >> From: Kumar Gala [mailto:galak at kernel.crashing.org]
> >> Sent: Wednesday, September 11, 2013 11:13 PM
> >> To: Zhao Qiang-B45475
> >> Cc: linuxppc-dev at lists.ozlabs.org; Liu Shengzhou-B36685
> >> Subject: Re: [PATCH] powerpc/p1010rdb:remove interrupts of
> >> ethernet-phy in device tree
> >>
> >>
> >> On Sep 10, 2013, at 10:49 PM, Zhao Qiang wrote:
> >>
> >>
> >> NAK.  The device tree should represent the HW not what drivers decide
> >> to do with it.
> >>
> >> If different board revs have different interrupt signals than create
> >> dts's to handle the 2 board revs.
> >>
> >> - k
> >>
> > You mean we need to create p1010rdb-pa.dtsi and p1010rdb-pb.dtsi
> replacing current p1010rdb.dtsi just because of the unused phy interrupt?
> > and phy interrupt is not present in those dts of P3/P4/P5 platforms.
> > Actually currently many hardware are not present in dts, such as a lot
> of i2c devices, temperature monitor, etc.
> >
> > -Shengzhou
> >
> 
> I'm saying of the board revs are different w/regards to how the PHY
> interrupt is wired, than create two .dts one for each of the board revs.
> 
> If the p3/p4/p5 platforms are missing the phy interrupt in the .dts than
> its an error.
> 
> Other devices like i2c, temp mon, etc should be added.  There is a
> difference between something not existing because people haven't gotten
> around to it / there isn't a binding vs a using the lack of information
> as a configuration mechanism.
> 
> - k
> 
> 

Kumar, please advice your solution, thanks.

-zhaoqiang