[PATCH] powerpc/p1010rdb:remove interrupts of ethernet-phy in device tree

[Liu Shengzhou-B36685]

> -----Original Message-----
> From: Kumar Gala [mailto:galak at kernel.crashing.org]
> Sent: Wednesday, September 11, 2013 11:13 PM
> To: Zhao Qiang-B45475
> Cc: linuxppc-dev at lists.ozlabs.org; Liu Shengzhou-B36685
> Subject: Re: [PATCH] powerpc/p1010rdb:remove interrupts of ethernet-phy in
> device tree
> 
> 
> On Sep 10, 2013, at 10:49 PM, Zhao Qiang wrote:
> 
> > Since P1010RDB-PA and P1010RDB-PB boards use different external PHY
> > interrupt signals.
> > And actually the PHY interrupt is not used effectively with
> > corresponding interrupt handler.
> > So we can remove the interrupts node without side-effect to comply
> > with both P1010RDB-PA and P1010RDB-PB.
> >
> > Signed-off-by: Shengzhou Liu <Shengzhou.Liu at freescale.com>
> > Signed-off-by: Zhao Qiang <B45475 at freescale.com>
> > ---
> > arch/powerpc/boot/dts/p1010rdb.dtsi | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> 
> NAK.  The device tree should represent the HW not what drivers decide to do with
> it.
> 
> If different board revs have different interrupt signals than create dts's to
> handle the 2 board revs.
> 
> - k
> 
You mean we need to create p1010rdb-pa.dtsi and p1010rdb-pb.dtsi replacing current p1010rdb.dtsi just because of the unused phy interrupt?
and phy interrupt is not present in those dts of P3/P4/P5 platforms.
Actually currently many hardware are not present in dts, such as a lot of i2c devices, temperature monitor, etc.

-Shengzhou