[PATCH V3 1/2] powerpc/85xx: Add QE common init functions

Xie Xiaobo-R63061 r63061 at freescale.com
Fri Sep 6 19:52:19 EST 2013


Hi Scott,

I already remove these code from the P1025TWR platform file(see the 2/2 patch). Do you means I also need to remove these codes from the others platforms and use the common call instead? 
Thank you.

Best Regards
Xie Xiaobo
-----Original Message-----
From: Wood Scott-B07421 
Sent: Thursday, September 05, 2013 12:27 AM
To: Xie Xiaobo-R63061
Cc: linuxppc-dev at lists.ozlabs.org; galak at kernel.crashing.org
Subject: Re: [PATCH V3 1/2] powerpc/85xx: Add QE common init functions

On Mon, 2013-09-02 at 18:11 +0800, Xie Xiaobo wrote:
> Define two QE init functions in common file, and avoid the same codes 
> being duplicated in board files.
> 
> Signed-off-by: Xie Xiaobo <X.Xie at freescale.com>
> ---
> V3 -> V2: Nochange
> 
>  arch/powerpc/platforms/85xx/common.c  | 47 
> +++++++++++++++++++++++++++++++++++
>  arch/powerpc/platforms/85xx/mpc85xx.h |  8 ++++++
>  2 files changed, 55 insertions(+)

Don't just copy it; remove it from the place you copied from and have that code call the common version.

-Scott




More information about the Linuxppc-dev mailing list